On Mon, Mar 11, 2019 at 12:08:42PM +0100, Daniel Vetter wrote:
On Mon, Mar 04, 2019 at 03:07:38PM -0800, Lucas De Marchi wrote:
On Mon, Mar 04, 2019 at 11:12:21PM +0200, Jani Nikula wrote:
> On Mon, 04 Mar 2019, Lucas De Marchi <[email protected]> wrote:
> > We had some small problems when calling dim setup. This should
> > hopefully fix them all, making it easier to setup a new environment
> > like I was doing.
> >
> > Now setting up the environment from scratch has a bigger chance of
> > working. Maybe we can update the docs with something like:
> >
> > curl -O \
> > https://gitlab.freedesktop.org/drm/maintainer-tools/raw/master/dim >
~/bin/dim
> > chmod +x ~/bin/dim
> > DIM_PREFIX=/path/to/setup/the/project dim setup
>
>
> I think the documentation should be to start by cloning the
> maintainer-tools repo, and continue from there.
yeah, as long as that's done inside DIM_PREFIX, it should be good.
Documentation idea:
export DIM_PREFIX=/path/to/setup/the/project
I'd start with .dimrc and putting your path in there instead of this. But
this works too I guess, a bit a bikeshed.
have you seen the update to the docs I sent?
cd $DIM_PREFIX
git clone https://gitlab.freedesktop.org/drm/maintainer-tools.git
./maintainer-tools/dim setup
After that mention the .dimrc in which some customizations can be made,
including the DIM_PREFIX above, as well as keeping the maintainer-tools
on PATH (although lately I'm just calling ../maintainer-tools/dim)
Yeah makes sense, and more what we've been aiming for than your patch 4.
On patches 1-3: Acked-by: Daniel Vetter <[email protected]>
thanks
Not sure what to do with patch 4 ...
I think it makes no harm and covers the case maintainer-tools is not
there. But it may be a bad option if the user is calling dim from
elsewhere.
Lucas De Marchi
I also miss a --non-interactive or the like so dim doesn't keep asking
me questions about the name of the remotes.
Sounds like a good idea. Making it a global dim option is probably
simplest, and makes sense. We could then have a small wrapper function,
for consistency and reuse (like we have with warn_or_fail, maybe
ask_user_default or something like that).
-Daniel
Lucas De Marchi
>
> BR,
> Jani.
>
> >
> > Another thing we may want to improve: add a --no-interactive or change
> > the default behavior so dim just do the right thing without asking.
> > Thoughts?
> >
> > Lucas De Marchi (4):
> > dim: clone in the right dir
> > dim: do all setup relative to $DIM_PREFIX
> > dim: update branches after setup
> > dim: automatically clone maintainer-tools repo
> >
> > dim | 32 +++++++++++++++++++-------------
> > 1 file changed, 19 insertions(+), 13 deletions(-)
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dim-tools mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dim-tools
