On Tue, 6 Aug 2019 at 11:52, Daniel Vetter <[email protected]> wrote:
>
> On Tue, Aug 6, 2019 at 12:50 PM Daniel Vetter <[email protected]> wrote:
> >
> > On Tue, Aug 6, 2019 at 12:42 PM Jani Nikula <[email protected]> wrote:
> > >
> > > Make it possible for the server side git pre-receive hook to determine
> > > the client is dim and refuse the push otherwise.
> > >
> > > Obviously it's possible to set the push-option manually on the git
> > > command line as well, but there's really no plausible denial in that
> > > case.
> > >
> > > Cc: Daniel Stone <[email protected]>
> > > Cc: Daniel Vetter <[email protected]>
> > > Cc: Emil Velikov <[email protected]>
> > > Signed-off-by: Jani Nikula <[email protected]>
> [stupid gmail]
>
> I think a
>
> function dim_push
> {
> git push $DRY_RUN $dim_fdo_cookie $@
> }
>
> Would be really nice refactor. Except for the 1 case where we use $DRY
> and have a reason.
>
I agree that minimising the duplicated is a plus, yet dim_push already exists:
function dim_push
{
dim_push_branch $(git_current_branch) "$@"
}
Regardless, the patch covers _all_ the "git push" instances in DIM and is:
Reviewed-by: Emil Velikov <[email protected]>
-Emil
_______________________________________________
dim-tools mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dim-tools
