On Mon, 05 Aug 2019, Arkadiusz Hiler <[email protected]> wrote:
> If the commit range that is being checked with 'dim sparse' introduces
> new Kconfig options 'make' prompts us for our opinion. Since we are
> capturing the stdout and -err the user sees nothing and we are seemingly
> stuck.
>
> To avoid that and be as non-interactive as possible let's just squeeze
> 'make olddefconfig' in-between 'git checkout' and the actual 'make'.
>
> Reported-by: Jani Nikula <[email protected]>
> Signed-off-by: Arkadiusz Hiler <[email protected]>

Thanks, pushed.

BR,
Jani.

> ---
>  dim | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/dim b/dim
> index a71c5f2..5556cf7 100755
> --- a/dim
> +++ b/dim
> @@ -1788,6 +1788,7 @@ function dim_sparse
>       # make the initial reference build
>       commits=( $(git rev-list --reverse $range) )
>       git checkout --detach  ${commits[0]}~ > /dev/null 2>&1
> +     make olddefconfig > /dev/null 2>&1
>       make -j8 drivers/gpu/drm/ > /dev/null 2>&1
>  
>       for commit in "${commits[@]}"; do
> @@ -1795,6 +1796,7 @@ function dim_sparse
>               prev_sr="$(make C=1 -j$(nproc) drivers/gpu/drm/ 2>&1 
> 1>/dev/null)"
>  
>               git checkout --detach $commit >/dev/null 2>&1
> +             make olddefconfig > /dev/null 2>&1
>               sr="$(make C=1 -j$(nproc) drivers/gpu/drm/ 2>&1 1>/dev/null)"
>  
>               prev_remapped="$(echo "$prev_sr" | $remap_log <(git diff HEAD~ 
> | $remap_log))"

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dim-tools mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dim-tools

Reply via email to