On Mon, Oct 07, 2019 at 07:54:03PM +0200, Maxime Ripard wrote:
> The current dim code will create the tag using a local branch as an
> argument, but while we make sure to fetch the branch first in the callers,
> we don't actually make sure that any local change have been pushed.
> 
> Make sure it's the case before creating the tag.
> 
> Signed-off-by: Maxime Ripard <[email protected]>
> ---
>  dim | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dim b/dim
> index eafc1794f6e5..15f749254117 100755
> --- a/dim
> +++ b/dim
> @@ -1962,6 +1962,7 @@ function tag_branch
>       branch=$2
>       remote=$(branch_to_remote $branch)
>  
> +     $DRY git push $remote $branch

Same thing here. Otherwise lgtm.
-Daniel

>       tag_summary $branch | $DRY git tag -F- $tag "$branch@{upstream}"
>       $DRY git tag -a $DIM_GPG_KEYID -f $tag
>       $DRY git push $remote $tag
> -- 
> 2.23.0
> 
> _______________________________________________
> dim-tools mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dim-tools

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dim-tools mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dim-tools

Reply via email to