On 2002.07.11 23:11:05 +1000 Denis Oliver Kropp wrote: > Quoting Alex Song ([EMAIL PROTECTED]): > > hi, > > > > i was wondering why the DisplayLayerFunc SetDstColorKey have r g b as > > parameters and SetSrcColorKey has a 32bit key value ? for > > SetSrcColorKey the user program enters it as r g b and it gets converted to > > > a 32 bit number and passed to the driver, the driver would probably > > have to convert back to r g b anyway. can we make SetSrcColorKey same as > > SetDstColorKey ? > > > > i can do it and send a patch along with the other stuff if you like, it's > > just that it is a change to the driver API and i was making sure it was ok. > > > please tell me if you want me to do it or not. > > Would be nice, the 32bit key was a bad idea.
i have attached a patch which changes the SetSrcColorKey to accept r g b values instead of a 32bit key. the patch also includes small fixes to dfb_layers_hook_primary and dfb_layers_replace_primary, the device pointer was not set. cheers, alex
alex-SrcColorKey-PrimaryHook.patch
Description: Binary data
