Hi, Ville Syrj�l� <[EMAIL PROTECTED]> writes:
> I just studied the code a bit more and FillTriangle() is now also > possible. Works ok for packed formats but planar formats only draw to the > luma plane. Problem bwing that the spanline rasterizer sets rect.h = 1. > I've attached a fix for this. Bad thing is that it draws each chroma line > twice. Do you have a better fix in mind? hmmm, now that you mention this ... how well does the current patch deal with an odd number of rows in FillRectangle? > AFAICS your patch doesn't check what drawing operation is requested. So > anything using gDrawLine() will succeed but the results will not be > correct. I removed it since your patch duplicated the code that checks the drawing operation quite often. We should perhaps try to find a better place for the check. Before YUV surfaces have been introduced the software driver used to provide fallbacks for all operations. Since then we broke this rule since implementing all operations for all pixel formats would be a major effort and would add a good amount of code that would rarely be used (if ever). On the other hand it would be nice to support all kinds of drawing operations for YUV surfaces. I think they could be implemented by adding a few more steps to the rendering pipeline instead of adding extra code to all drawing functions. I'll see if I can spend some time on this next week... Salut, Sven -- Info: To unsubscribe send a mail to [EMAIL PROTECTED] with "unsubscribe directfb-dev" as subject.
