At 08:36 PM 22/08/2002, Sven Neumann wrote:
>Hi,
>
>Alex Song <[EMAIL PROTECTED]> writes:
>
> > this is a patch for the savage driver, it adds secondary flipping
> > support and also works with the latest changes in fbdev.c and primary
> > layer functions.
>
>basically looks good, but see my comments below...
>
> > Index: src/core/fbdev/fbdev.c
> > ===================================================================
> > RCS file: /cvs/directfb/DirectFB/src/core/fbdev/fbdev.c,v
> > retrieving revision 1.6
> > diff -u -p -r1.6 fbdev.c
> > --- src/core/fbdev/fbdev.c 20 Aug 2002 17:53:14 -0000 1.6
> > +++ src/core/fbdev/fbdev.c 22 Aug 2002 03:55:58 -0000
> > @@ -522,7 +522,7 @@ DFBResult dfb_fbdev_wait_vsync()
> > return DFB_OK;
> > }
> >
> > -static DFBResult init_modes()
> > +DFBResult init_modes()
> > {
> > dfb_fbdev_read_modes();
> >
> > Index: src/core/fbdev/fbdev.h
> > ===================================================================
> > RCS file: /cvs/directfb/DirectFB/src/core/fbdev/fbdev.h,v
> > retrieving revision 1.3
> > diff -u -p -r1.3 fbdev.h
> > --- src/core/fbdev/fbdev.h 16 Aug 2002 08:32:28 -0000 1.3
> > +++ src/core/fbdev/fbdev.h 22 Aug 2002 03:55:58 -0000
> > @@ -110,7 +110,7 @@ DFBResult dfb_fbdev_leave( bool emergenc
> > DFBResult dfb_fbdev_wait_vsync();
> >
> > VideoMode *dfb_fbdev_modes();
> > -
> > +DFBResult init_modes();
> >
> >
> > void dfb_primarylayer_register( GraphicsDevice *device );
>
>if we really need to expose this internal function it needs to be
>renamed (dfb_fbdev_init_modes() ?!). I wonder however why the Savage
>driver needs it while other gfxdrivers can obviously be implemented
>w/o it.
because other graphics drivers only implement secondary stuff while the
savage driver does primary stuff. init_modes() is currently called from
primaryInitLayer() and since the savage drivers hook into those primary
functions it needs to be able to access certain primary layer functions. it
didn't need to be there before because the mode initialisation was done in
dfb_fbdev_init (something like that) and now that it has moved to
primaryInitLayer(), init_modes() need to be exposed.
hope that makes it clear.
cheers,
alex
--
Info: To unsubscribe send a mail to [EMAIL PROTECTED] with
"unsubscribe directfb-dev" as subject.
