thanks for your quick response. and else should be commented, too. then we
can set variable format.

so is it a bug? and if yes, will you fix it recently?

thanks again and best regards,

ln
----- Original Message -----
From: "Sven Neumann" <[EMAIL PROTECTED]>
To: "Liu, Nian(Neo)" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Wednesday, July 30, 2003 4:45 PM
Subject: Re: [directfb-dev] Re: pixmap with depth equals -1


> Hi,
>
> "Liu, Nian\(Neo\)" <[EMAIL PROTECTED]> writes:
>
> > attachment is a test sample and make file. it works well for GTK+
> > for X11, and got signal 11 in GTK+ for DirectFB.
> >
> > for me, it seem in gdk_pixmap_new, when window==_gdk_parent_root and
> > depth==-1, DirectFB hasn't handle it correctly. correct me here if
> > i'm wrong.
>
> Well, the problem here is that DirectFB doesn't have a root window and
> gdk-directfb tries to behave as if it did. Obviously, there's a
> problem here, when gdk_pixmap_new() accesses draw_impl->surface.
>
> Can you check if the following patch fixes it for you:
>
> --- gdkpixmap-directfb.c     27 Dec 2002 17:55:33 -0000 1.32
> +++ gdkpixmap-directfb.c     30 Jul 2003 08:44:12 -0000
> @@ -142,13 +142,7 @@ gdk_pixmap_new (GdkWindow *window,
>
>    if (depth == -1)
>      {
> -      draw_impl =
> -        GDK_DRAWABLE_IMPL_DIRECTFB (GDK_WINDOW_OBJECT (window)->impl);
> -
> -      g_return_val_if_fail (draw_impl != NULL, NULL);
> -
> -      draw_impl->surface->GetPixelFormat (draw_impl->surface, &format);
> -      depth = DFB_BITS_PER_PIXEL (format);
> +      depth = GDK_WINDOW_OBJECT (window)->depth;
>      }
>    else
>      {
>



-- 
Info:  To unsubscribe send a mail to [EMAIL PROTECTED] with 
"unsubscribe directfb-dev" as subject.

Reply via email to