On Sonntag, 8. August 2004 11:56, Stefan Lucke wrote:

[ .. ]

> 
> Add some trace code to matrox_bes.c and I think cropright values is not correct.
>  (720x576)area = 90 0 540 576 dest  :(0,32 1280x960)
> source:(90,0 540x288)
> crop A:(0,0) (0,0)
> crop B:(5898240,0) (0,0)
>  OK !!
> 0 / 1280; 32 / 1024; 1280 / 1280; 960 / 1024
> 

[ .. ]

I adjusted setting BESHSRCEND to that from X11 mga_video.c (here matrox_bes.c line 
585):

     mbes->regs.besHSRCEND  = ((source.w - 1) << 16) - cropright;
     mbes->regs.besHSRCEND  = ((source.x+source.w)-0x00010000 - 1)&0x03fffffc;

With that horizontal scaleing works as expected. But it should be further modified
to take cropright into account.

> > 
> > I just noticed that the matrox code had a bug with vertical cropping. Fix
> > is already in cvs...

Vertical scaled crop is still not right. Displayed area is shifted a bit up
(top black bar is smaller than bottom one) and displayed content is shifted up too.


Stefan Lucke



Reply via email to