On Sat, Sep 25, 2004 at 12:52:49AM -0300, Rob Shortt wrote:In vo_dfbmga.c at around line 428 it resets no_input to 1 if use_bes is true. I would rather that line be removed and have it default to 1 instead of use_input = !getenv( "DISPLAY" ). Does that make sense?
Not really. If use_input defaulted to 1 all users who use XDirectFB + dfbmga @ CRTC2 would get all keypresses twice. And if it defaulted to 0 BES users would get no input at all.
Ahh, I see. That makes sense, I didn't think about XDirectFB.
I'll change the code so that [no]input options really override any defaults including the BES case. That should fix your case and not cause any changes to other users.
Thanks. That will certainly fix my problem, maintaining noinput in the config is business as usual.
Also, I am wondering why there are references to the primary layer throughout this file when they aren't being used. In my setup (and Freevo w/ dfbmga in general) I would prefer to keep mplayer from touching the primary layer if I tell it to use bes only, we are doing our own thing on the primary layer.
I could add an option for that but I don't see what good it would do since the primary layer is completely covered by the BES.
We're not doing anything on that surface while video is playing so that's not really a problem, I was just being paranoid.
Are the references to primary there a sign of something yet to come or can / should they be removed? I have made all these changes in my working copy and things are going well.
The primary layer is put into exclusive mode so that windowstack updates don't hinder performance. In the future it could also be used to make a window to house the BES.
Windowed BES would be really cool. Have you given any thought to adding any windowed mode options to vo_dfbmga or vo_directfb(2). I would definately like to see an option for windowed more and also to output to any premade window's surface by passing a window id or surface id to mplayer. What are your thoughts on that? I was thinking of attempting a patch for that once my TODO list gets a bit smaller.
Thanks, -Rob
