Quoting Claudio Ciccani:
> 
> I have attached a proposal of API changes for IDirectFBVideoProvider
> that implements some missing feataures keeping the maximum compatibility
> with the current interface.

Keeping compatibility is nice, but this interface is used rarely because
of its insufficiency. Therefore, it would be better to change or even
redesign it from scratch.

> The patch adds two methods:
> - SetSpeed() can be used to change playback speed, it takes a speed
>   multiplier as argument (> 0.0, 1.0 for normal speed, 0.0 for pause);
>   calling Play() resets the speed multiplier to 1.0; if playback was
>   stopped/paused using Stop(), SetSpeed() doesn't take effect.

That's nice ;)

> - GetRatio() can be used to query the video aspect ratio.

Maybe GetRatio() is too general here... GetAspectRatio()?

> To notify end of playback, GetPos() returns DFB_EOF (new errorcode).

I don't think it should cause an error if GetPos() is called after
playback finished, because the position is still valid, i.e. the end.

What about a separate method to query the playback status?

-- 
Best regards,
  Denis Oliver Kropp
 
.------------------------------------------.
| DirectFB - Hardware accelerated graphics |
| http://www.directfb.org/                 |
"------------------------------------------"

_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

Reply via email to