Quoting Marko Mäkelä: > On Tue, Sep 13, 2005 at 05:04:44PM +0200, Denis Oliver Kropp wrote: > > Quoting Marko Mäkelä: > > > I reported this as Bug #24 in the bug tracking system > > > <http://www.directfb.org/mantis/view.php?id=24>. The bug report > > > includes a patch. A corresponding patch is included in the most > > > recent 0.1.3 release of the vdr-softdevice plugin. > > > > Thanks for the patch. However, I'd like to propose a different > > approach to fix that issue. Instead of adding new event types > > it might be better to add a new event flag. This way it's compatible > > with older applications which expect press events and don't handle > > the new events. What about DIEF_REPEAT which is added to the event > > flags by the input driver? Newer applications can check if the flag > > is set for press events and old applications don't loose those events. > > You are the expert. The main thing is that the application can tell > key-press and key-repeat events apart.
:-) > > Also, it's true that you can't "#ifdef DIEF_REPEAT", but adding > > extra macros and ifdefs in the header doesn't look good in my opinion. > > If an application developer really wants to support different versions > > of 0.9.23, he/she should add a check to the configure script of the > > application and define a custom macro. > > The vdr-softdevice plugin just got a configure script, so this is no > longer a problem. I dislike configure scripts, because they cause > problems in cross-compilation. But it doesn't really matter. Besides, > if 0.9.23 is released soonish, then the application can simply check > the version number macros. You should follow certain guide lines to have configure scripts working with cross compilation, that's true... 0.9.23 is very soonish. > Please let me know when the fix is in cvs, so I can prepare a patch for > the vdr-softdevice plugin. I'll fix it today (as in about 14 hours). -- Best regards, Denis Oliver Kropp .------------------------------------------. | DirectFB - Hardware accelerated graphics | | http://www.directfb.org/ | "------------------------------------------" _______________________________________________ directfb-dev mailing list [email protected] http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
