Hi,

I don't think I've seen this mentioned on the mailing lists but I may have 
missed it...I've just found out why my new kernel wasn't working nicely with 
viafb from CVS when patched with Mark Adams's field-sync patch.

I'm not sure quite what kernel version this happened (possibly 2.6.16) but the 
current CVS of linux-viafb has an incorrect prototype for fb_ioctl for 
current kernels. The following patch works for me with a 2.6.16.5 kernel but 
it probably wants some #ifs adding to check kernel version:

--- via_fbobj.c.orig    2006-04-15 14:47:12.000000000 +0100
+++ via_fbobj.c 2006-04-15 14:48:28.000000000 +0100
@@ -1273,8 +1273,8 @@
     return 0;
 }

-static int viafb_ioctl(struct inode *inode, struct file *file, unsigned int 
cmd,
-    unsigned long arg, struct fb_info *info)
+static int viafb_ioctl(struct fb_info *info, unsigned int cmd,
+    unsigned long arg)
 {
     switch (cmd) {
         case FBIO_WAITFORVSYNC:

Without the patch, I only got a compiler warning and playback was jerky 
because it wasn't doing ioctls properly to sync playback!

Cheers,

Laz

_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

Reply via email to