I think we need to expand FillRect by +1

Here is a propsed patch see if it works for you.

Index: gdkdrawable-directfb.c
===================================================================
RCS file: /cvs/gnome/gtk+/gdk/directfb/gdkdrawable-directfb.c,v
retrieving revision 1.4
diff -u -r1.4 gdkdrawable-directfb.c
--- gdkdrawable-directfb.c      14 Jun 2006 21:54:25 -0000      1.4
+++ gdkdrawable-directfb.c      6 Jul 2006 23:57:53 -0000
@@ -445,8 +445,8 @@
               impl->surface->FillRectangle (impl->surface,
                                             region->x1,
                                             region->y1,
-                                            region->x2 - region->x1,
-                                            region->y2 - region->y1);
+                                            region->x2 - region->x1+1,
+                                            region->y2 - region->y1+1);
             }
         }





On 7/6/06, Davide Viti <[EMAIL PROTECTED]> wrote:
> Hi Mike,
>
> On Mon, Jul 03, 2006 at 02:12:39PM -0700, Mike Emmel wrote:
> > The clip was expanded recently in CVS I'm not sure you have the fix.
> > look for rects with a width+/-1 thats the change.
> > So the best bet is to  someone to test agianst current cvs
> > and maybe backport the fix.
>
> I reverted the changes involving +-1 in
> http://cvs.gnome.org/viewcvs/gtk%2B/gdk/directfb/gdkdrawable-directfb.c?r1=1.4&r2=1.2
>
> and the ugly lines ([1]) reported by Frans disappear.
> some of those +-1 are certainly needed to fix [2], so mass
> changing those fixed a bug but create a couple more :)
> Could you please help us out to fix those?
>
> > And report bugs to the gnome bug tracker now.
>
> Just filed #346810
>
> TIA,
> Davide
>
> [1] http://people.debian.org/~fjp/d-i/g-i_2.8.18_display-weirdness.png
> [2] http://bugzilla.gnome.org/show_bug.cgi?id=330824
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
>
> iD8DBQFErYkjax2slmJA7HoRAoPCAJ9MK8fhM8eqz/DCSYWOHYby2Ce07wCgpbmx
> j2exW5BsE+4zDDWiq86Y59g=
> =Teao
> -----END PGP SIGNATURE-----
>
>
>

_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

Reply via email to