On Tue, Aug 01, 2006 at 01:16:01PM -0700, Mike Emmel wrote:
> Attached is the patch for window properties.
>
> Comments suggestions ?
I have some comments on coding style.
> Index: include/directfb.h
> ===================================================================
> RCS file: /cvs/directfb/DirectFB/include/directfb.h,v
> retrieving revision 1.304
> diff -u -r1.304 directfb.h
> --- include/directfb.h 17 Jul 2006 13:12:21 -0000 1.304
> +++ include/directfb.h 1 Aug 2006 20:14:01 -0000
> @@ -4324,6 +4324,34 @@
> /** Appearance and Behaviour **/
>
> /*
> + * Set property controlling appearance and behaviour of the window.
> + */
> + DFBResult (*SetProperty) (
> + IDirectFBWindow *thiz,
> + char *key,
> + void *value,
> + void **old_value
Don't align the '*' characters. Instead old_value should be aligned
with value.
<snip>
> Index: src/core/wm.c
> ===================================================================
> RCS file: /cvs/directfb/DirectFB/src/core/wm.c,v
> retrieving revision 1.12
> diff -u -r1.12 wm.c
> --- src/core/wm.c 16 Jul 2006 10:15:29 -0000 1.12
> +++ src/core/wm.c 1 Aug 2006 20:14:02 -0000
> @@ -563,6 +563,7 @@
>
> return wm_local->funcs->GetInsets(stack,window,insets);
> }
> +
> /**
> Give the wm a chance to override the windows configuration
> **/
Personally I prefer cosmetic changes to go in separately. I'm not sure
what other developers think about this issue though.
> @@ -652,6 +653,65 @@
> return ret;
> }
>
> +/**
> + * Let the wm set a property on a window
> + */
> +DFBResult
> +dfb_wm_set_window_property( CoreWindowStack *stack,
> + CoreWindow *window,
Don't use tabs.
> + char *key,
> + void *value,
> + void **old_value)
These should aligned with first argument, and again the '*'
alignment issue. Space between the last argument and and ')'.
> +
> + return
> wm_local->funcs->SetWindowProperty(stack,wm_local->data,stack->stack_data,
> +
> window,window->window_data,
> + key,value,old_value);
> +}
Space after ',' and '(', and before ')'.
... More of the same in the rest of the patch.
--
Ville Syrjälä
[EMAIL PROTECTED]
http://www.sci.fi/~syrjala/
_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
