Denis Oliver Kropp wrote:
Denis Oliver Kropp wrote:
[EMAIL PROTECTED] wrote:
Hello,

I did some investigations regarding the reference counts at con- and
destruction and drew a chart (see attached constr_destr_chart.txt). As
you can see there, at destruction time there is no equvalent call to
gdk_directfb_event_windows_add().
Adding a gdk_directfb_event_windows_remove() function and callig it in
_gdk_windowing_window_destroy() (patch is attached) seems to fix it (I
think), or was such a function (and its call) omitted on purpose?

Thanks for your great investigation!

I think Mike should have a look as he's more into that code than me now.

Of course, the DetachEventBuffer() method is quite new. Mike, please apply.

I just tested Simon's patch on gtk+ 2-10 branch and DFB 1.0 and it actually fixes memory leaks which oterwise would occourr when destroying windows. The patch seems also to be stable: i had along GIMP session and experienced no crashes. Because DirectFB >= 1.0 is needed for the patch to work, i added the #ifdef's you find in this mail's attachment (it's Simon's original patch with #ifdef's aded where needed).
I think this patch should be applied also to gtk+ trunk, of course.

Thanks Simon!

Thanks a lot from me too :)

Attilio

ps

Mike, if you have no time to apply the patch upstream, i can take care of that.

Attachment: proposed_memeleak_fix_DFB-0.9.25_compatible.txt
Description: plain/text

_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

Reply via email to