On Mon, Sep 03, 2007 at 10:38:23AM +0100, Kieran Bingham wrote: > Hi Guys, > > I have been looking at the differences between DirectFB's FBdev subsystem > between version 1.0.0 and 1.0.1, and I believe I have found a bug. > > When a graphics driver has its own primary layer hooks implementation, and > then defers to fbdev for primarySetRegion(), dfb_fbdev_set_mode() is called > unnecessarily. > > The original implementation in DFB1.0.0 would only call dfb_fbdev_set_mode() > if a flag indicated a change, however now that dfb_fbdev_set_mode() is in > the default case of a switch statement, it is always called regardless. This > has the side effect of resetting the panning, when features implemented in > the graphics driver are called such as setting opacity.
Oops. Right you are. > The Git tree shows the change on the following commitdiff titled "Add source > rectangle support to fbdev layer." > http://git.directfb.org/?p=core/DirectFB.git;a=commitdiff;h=18e71c700d6d6dea3981da42118639f298afe3e8#patch1 > > > The following patch returns the original expected behaviour, whilst > continuing the new source rectangle support. > <patch snipped> I would rather add a CLRCF_NONE case to the switch statement. -- Ville Syrjälä [EMAIL PROTECTED] http://www.sci.fi/~syrjala/ _______________________________________________ directfb-dev mailing list [email protected] http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
