Sven Neumann wrote:
Hi,I am trying to put the final pieces together to make the new PXA3xx acceleration work. We now have an accelerator ID for the pxafb framedriver (on its way to the upstream kernel tree): (*) DirectFB/FBDev: Found 'PXA' (ID 99) with frame buffer at 0xa7c00000, 4096k (MMIO 0x00000000, 0k) I have already changed driver_probe() in the pxa3xx gfxdriver to probe for this ID. But unfortunately dfb_gfxcard_get_accelerator() won't return the accelerator ID, but -1. This is due to the following code in fbdev.c: static int system_get_accelerator( void ) { [ snip: some code removed for clarity ] if (dfb_config->accelerator) return dfb_config->accelerator; if (dfb_fbdev->shared->fix.mmio_len > 0) return dfb_fbdev->shared->fix.accel; return -1; } Is there a particular reason for this check? Would other drivers break if I removed this line of code? How can I properly enable drivers that don't use any MMIO ?
I think it can be removed without issues, but Ville might know more, AFAIR, he has added the code. -- Best regards, Denis Oliver Kropp .------------------------------------------. | DirectFB - Hardware accelerated graphics | | http://www.directfb.org/ | "------------------------------------------" _______________________________________________ directfb-dev mailing list directfb-dev@directfb.org http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
