Hi, 
        No. It is much better to resolve it upper.
        Because if we want to fix dfb_convert_to rgb32(), we need to add one 
interface to it to tell it "palette" information. And if we do this, not only 
dfb_convert_to_rgb32, but also other dfb_convert_to_xxxx should do this.

-----------
    *^_^*
Many thanks & Best Regards
Zhao Juan

-----Original Message-----
From: directfb-dev-boun...@directfb.org 
[mailto:directfb-dev-boun...@directfb.org] On Behalf Of Andre DRASZIK
Sent: Thursday, April 01, 2010 10:53 PM
To: directfb-dev
Subject: Re: [directfb-dev] [PATCH] Fix LUT8 convert to rgb32 error

Hi,

shouldn't dfb_convert_to_rgb32() be fixed instead?

Cheers,
Andre'


On Thu, 2010-03-25 at 13:34 +0800, Zhao, Juan J wrote:
> Attached is a patch for DirectFB based on tip commit:
> 3a9360cb003f605be22134b54eeeee1858d727bd. 
> DSPF_LUT8 pixel format is not correctly handling in update_screen in
> system/x11/primary.c. And this caused error message "[unsupported
> format]***[convert.c:987 in dfb_convert_to_rgb32()]" when running demos
> such as df_fire.
> 
> ----
>  *^_^*
> Many thanks & Best Regards
> Juan Zhao
> _______________________________________________
> directfb-dev mailing list
> directfb-dev@directfb.org
> http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev


_______________________________________________
directfb-dev mailing list
directfb-dev@directfb.org
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
_______________________________________________
directfb-dev mailing list
directfb-dev@directfb.org
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

Reply via email to