Hi, Strelchun, Timothy wrote: > Ideally, for compatibility with existing older drivers I think the > StretchBlit behavior should be the same as before. Thus, if the > rects were 1:1 and if a driver obtains better performance from > an actual 1:1 blit being performed by the driver rather than > a scaled blit that behavior could still occur.
The patch doesn't change behaviour of that. > I know it will complicate the implementation, but I think the > implementation of the dfb_gfxcard_batchstretchblit function > should allow fully disjointed GPU/CPU scaled blit operations > [...] > It appears that your > implementation will allow the fallback to CPU, but > then does not return to GPU operations. BatchStretchBlit() operates similar to BatchBlit(), which has the same limitation. Such an optimisation could be done as a separate step. Unless a rectangle is too large to fit into a hardware's limitations, why do you think switching between CPU/GPU would be something that happens regularly? > Another thing to consider is to add a DFXL_BATCHSTRETCHBLIT flag for > the driver to report support for it. If not supported, the DFB > core software should emulate by just calling standard stretch > sblit iteratively. This is how both, BatchStretchBlit() and BatchBlit() work. Why is an extra flag needed for BatchStretchBlit()? > BTW: I would recommend that the new BatchStretchBlit function > be added at the end of the interface function table to prevent > non-recompiled programs have having issues (otherwise the > minor version should be increased). I added it at the end. Nevertheless versions have to be changed (the interface age has to be set to 0 I believe), otherwise apps compiled against the new version will crash when running against the old version... Cheers, Andre' > > Regards, > Timothy > > -- > > Timothy Strelchun > CE Software Engineering > Digital Home Group > Intel Corporation > >> -----Original Message----- >> From: directfb-dev-boun...@directfb.org >> [mailto:directfb-dev-boun...@directfb.org] On Behalf Of André Draszik >> Sent: Monday, December 13, 2010 8:43 AM >> To: directfb-dev@directfb.org >> Subject: [directfb-dev] batch stretch blit >> >> Hi, >> >> attached is an updated version of the batched stretchblit. >> >> All the code duplication of batched vs. non batched versions >> has been removed... >> >> Not sure how to best deal with the calling of dfb_gfxcard_blit( srect, >> drect->x, drect->y, state ); if the rectangle sizes match. >> Should dfb_state_check()/_acquire() maybe do DFXL_BLIT | >> DFXL_STRETCHBLIT in the first place, instead of releasing and >> releasing and reacquiring the STRETCHBLIT state? >> >> >> Cheers, >> Andre' >> > _______________________________________________ > directfb-dev mailing list > directfb-dev@directfb.org > http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev _______________________________________________ directfb-dev mailing list directfb-dev@directfb.org http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
