Author: akarasulu Date: Fri Dec 10 22:44:30 2004 New Revision: 111583 URL: http://svn.apache.org/viewcvs?view=rev&rev=111583 Log: Changes ...
o found bug where we were not returning the response from a catch and success was overriding error responses o fixed bug in all handlers that seemed to have this code copied :( Modified: incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/AddHandler.java incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/CompareHandler.java incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/DeleteHandler.java incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyDnHandler.java incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyHandler.java incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/SearchHandler.java Modified: incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/AddHandler.java Url: http://svn.apache.org/viewcvs/incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/AddHandler.java?view=diff&rev=111583&p1=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/AddHandler.java&r1=111582&p2=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/AddHandler.java&r2=111583 ============================================================================== --- incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/AddHandler.java (original) +++ incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/AddHandler.java Fri Dec 10 22:44:30 2004 @@ -72,6 +72,8 @@ { resp.getLdapResult().setMatchedDn( e.getResolvedName().toString() ); } + + return resp; } resp.getLdapResult().setResultCode( ResultCodeEnum.SUCCESS ); Modified: incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/CompareHandler.java Url: http://svn.apache.org/viewcvs/incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/CompareHandler.java?view=diff&rev=111583&p1=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/CompareHandler.java&r1=111582&p2=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/CompareHandler.java&r2=111583 ============================================================================== --- incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/CompareHandler.java (original) +++ incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/CompareHandler.java Fri Dec 10 22:44:30 2004 @@ -89,6 +89,8 @@ { resp.getLdapResult().setMatchedDn( e.getResolvedName().toString() ); } + + return resp; } resp.getLdapResult().setMatchedDn( req.getName() ); Modified: incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/DeleteHandler.java Url: http://svn.apache.org/viewcvs/incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/DeleteHandler.java?view=diff&rev=111583&p1=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/DeleteHandler.java&r1=111582&p2=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/DeleteHandler.java&r2=111583 ============================================================================== --- incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/DeleteHandler.java (original) +++ incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/DeleteHandler.java Fri Dec 10 22:44:30 2004 @@ -75,6 +75,8 @@ { resp.getLdapResult().setMatchedDn( e.getResolvedName().toString() ); } + + return resp; } resp.getLdapResult().setResultCode( ResultCodeEnum.SUCCESS ); Modified: incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyDnHandler.java Url: http://svn.apache.org/viewcvs/incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyDnHandler.java?view=diff&rev=111583&p1=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyDnHandler.java&r1=111582&p2=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyDnHandler.java&r2=111583 ============================================================================== --- incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyDnHandler.java (original) +++ incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyDnHandler.java Fri Dec 10 22:44:30 2004 @@ -101,6 +101,8 @@ { resp.getLdapResult().setMatchedDn( e.getResolvedName().toString() ); } + + return resp; } resp.getLdapResult().setResultCode( ResultCodeEnum.SUCCESS ); Modified: incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyHandler.java Url: http://svn.apache.org/viewcvs/incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyHandler.java?view=diff&rev=111583&p1=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyHandler.java&r1=111582&p2=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyHandler.java&r2=111583 ============================================================================== --- incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyHandler.java (original) +++ incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/ModifyHandler.java Fri Dec 10 22:44:30 2004 @@ -78,6 +78,8 @@ { resp.getLdapResult().setMatchedDn( e.getResolvedName().toString() ); } + + return resp; } resp.getLdapResult().setResultCode( ResultCodeEnum.SUCCESS ); Modified: incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/SearchHandler.java Url: http://svn.apache.org/viewcvs/incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/SearchHandler.java?view=diff&rev=111583&p1=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/SearchHandler.java&r1=111582&p2=incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/SearchHandler.java&r2=111583 ============================================================================== --- incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/SearchHandler.java (original) +++ incubator/directory/eve/trunk/protocol/src/java/org/apache/eve/protocol/SearchHandler.java Fri Dec 10 22:44:30 2004 @@ -153,8 +153,6 @@ return Collections.singleton( resp ).iterator(); } - - }
