svn commit: r154428 - incubator/directory/authx/trunk/script/src/test/org/apache/authx/script/xml/Dom4JRuleSetBuilderTest.java

[vtence]

Author: vtence
Date: Sat Feb 19 09:29:33 2005
New Revision: 154428

URL: http://svn.apache.org/viewcvs?view=rev&rev=154428
Log:
Enhanced test coverage

Modified:
    
incubator/directory/authx/trunk/script/src/test/org/apache/authx/script/xml/Dom4JRuleSetBuilderTest.java

Modified: 
incubator/directory/authx/trunk/script/src/test/org/apache/authx/script/xml/Dom4JRuleSetBuilderTest.java
URL: 
http://svn.apache.org/viewcvs/incubator/directory/authx/trunk/script/src/test/org/apache/authx/script/xml/Dom4JRuleSetBuilderTest.java?view=diff&r1=154427&r2=154428
==============================================================================
--- 
incubator/directory/authx/trunk/script/src/test/org/apache/authx/script/xml/Dom4JRuleSetBuilderTest.java
 (original)
+++ 
incubator/directory/authx/trunk/script/src/test/org/apache/authx/script/xml/Dom4JRuleSetBuilderTest.java
 Sat Feb 19 09:29:33 2005
@@ -31,10 +31,6 @@
 
 import java.io.StringReader;
 
-/**
- * TODO: change or & and element to accept more than 2 children
- * TODO: introduce subject element alias for and operation
- */
 public class Dom4JRuleSetBuilderTest extends TestCase
 {
     public void testParsesDocumentAndAddsRulesToPolicy() throws Exception
@@ -181,7 +177,6 @@
                 "        <subjects>\n" +
                 "            <username>joeblow</username>\n" +
                 "            <group>canadians</group>\n" +
-                "            <role>developer</role>\n" +
                 "        </subjects>\n" +
                 "        <permissions>\n" +
                 "            <any/>\n" +
@@ -195,7 +190,7 @@
 
         assertEquals( Effects.GRANT, policy.evaluate( new 
DefaultAuthorizationRequest( Subjects.with( Usernames.joe() ), 
Permissions.anything() ) ).reduce() );
         assertEquals( Effects.GRANT, policy.evaluate( new 
DefaultAuthorizationRequest( Subjects.with( Groups.canadians() ), 
Permissions.anything() ) ).reduce() );
-        assertEquals( Effects.GRANT, policy.evaluate( new 
DefaultAuthorizationRequest( Subjects.with( Roles.developer() ), 
Permissions.anything() ) ).reduce() );
+        assertEquals( Effects.NOT_APPLICABLE, policy.evaluate( new 
DefaultAuthorizationRequest( Subjects.with( Roles.developer() ), 
Permissions.anything() ) ).reduce() );
     }
 
     public void testHasBuiltInSupportForAndOperationOnPredicates() throws 
Exception