tqchen commented on code in PR #42:
URL: https://github.com/apache/tvm-ffi/pull/42#discussion_r2370447078


##########
include/tvm/ffi/c_api.h:
##########
@@ -271,18 +277,33 @@ typedef struct {
      * when accessing the small str content.
      */
     uint32_t small_str_len;
+#if !defined(TVM_FFI_DOCUMENTATION)
   };
-  union {                 // 8 bytes
-    int64_t v_int64;      // integers
-    double v_float64;     // floating-point numbers
-    void* v_ptr;          // typeless pointers
-    const char* v_c_str;  // raw C-string
-    TVMFFIObject* v_obj;  // ref counted objects
-    DLDataType v_dtype;   // data type
-    DLDevice v_device;    // device
-    char v_bytes[8];      // small string
-    uint64_t v_uint64;    // uint64 repr mainly used for hashing
+#endif
+#if !defined(TVM_FFI_DOCUMENTATION)
+  union {  // 8 bytes
+#endif

Review Comment:
   interesting, i thought doxygen should work out of box as exhale kind of 
support it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to