tqchen commented on code in PR #96:
URL: https://github.com/apache/tvm-ffi/pull/96#discussion_r2422366120
##########
python/tvm_ffi/_optional_torch_c_dlpack.py:
##########
@@ -513,16 +508,66 @@ def load_torch_c_dlpack_extension() -> Any:
}
}
-int64_t TorchDLPackFromPyObjectPtr() {
- return reinterpret_cast<int64_t>(TorchDLPackFromPyObject);
+int TorchDLTensorFromPyObject(void* py_obj, DLTensor* out) {
Review Comment:
naming, make it consistent with the new term
TorchDLPackManagedTensorFromPyObjectNoSync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
