gemini-code-assist[bot] commented on code in PR #144:
URL: https://github.com/apache/tvm-ffi/pull/144#discussion_r2436290593
##########
CMakeLists.txt:
##########
@@ -296,7 +296,14 @@ endif ()
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/tvm/ffi/ DESTINATION
include/tvm/ffi/)
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dlpack/include/
DESTINATION include/)
install(TARGETS tvm_ffi_shared DESTINATION lib)
-install(TARGETS tvm_ffi_testing DESTINATION lib)
+# if tvm_ffi_testing is built, we also install it
Review Comment:
Consider adding a comment before the `if` block to explain the condition for
installing `tvm_ffi_testing`. This improves readability by clarifying why the
check is necessary.
##########
CMakeLists.txt:
##########
@@ -309,5 +316,9 @@ endif ()
if (NOT TVM_FFI_BUILD_PYTHON_MODULE)
# when building wheel, we do not ship static as we already ships source and
dll
- install(TARGETS tvm_ffi_static DESTINATION lib)
+ install(
+ TARGETS tvm_ffi_static
+ DESTINATION lib
+ OPTIONAL
+ )
Review Comment:
Consider adding a comment before the `if` block to explain the condition for
installing `tvm_ffi_static`. This improves readability by clarifying why the
check is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
