gemini-code-assist[bot] commented on PR #52: URL: https://github.com/apache/tvm-ffi/pull/52#issuecomment-3325615914
## Summary of Changes Hello @junrushao, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the `@c_class` decorator by integrating the `init` parameter into `field` definitions. This feature grants finer control over the generated Python `__init__` method for FFI-bound classes, enabling the exclusion of specific fields from the constructor's signature. This is particularly beneficial for fields with default values that are not required by the C++ FFI constructor, thereby increasing the flexibility and alignment of the FFI dataclass system with Python's native dataclass capabilities. ### Highlights * **Support for `field(init=...)`**: Introduced a new `init` boolean parameter to the `field` function, allowing developers to explicitly control whether a field is included in the generated Python `__init__` method's signature for `@c_class` decorated types. * **Flexible `__init__` generation**: The `method_init` function has been updated to differentiate between fields intended for the constructor signature (`init=True`) and those that are not (`init=False`), ensuring only relevant fields are passed to the underlying C++ FFI constructor. * **Python-side default initialization**: Fields marked with `init=False` that also specify a `default` or `default_factory` will now have their default values assigned on the Python side after the FFI constructor has been called, providing consistent behavior with standard Python dataclasses. * **Comprehensive testing**: New C++ and Python test cases (`TestCxxInitSubsetObj` and `_TestCxxInitSubset`) have been added to thoroughly validate the correct behavior of `field(init=False)` regarding `__init__` signature generation and default value assignment. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
