junrushao commented on code in PR #146: URL: https://github.com/apache/tvm-ffi/pull/146#discussion_r2436753708
########## tests/python/test_container.py: ########## @@ -15,12 +15,21 @@ # specific language governing permissions and limitations # under the License. import pickle +import sys from collections.abc import Sequence from typing import Any import pytest import tvm_ffi +if sys.version_info >= (3, 9): + # PEP 585 generics + from collections.abc import Sequence +else: # Python 3.8 + # workarounds for python 3.8 + # typing-module generics (subscriptable on 3.8) + from typing import Sequence Review Comment: Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
