gemini-code-assist[bot] commented on code in PR #165:
URL: https://github.com/apache/tvm-ffi/pull/165#discussion_r2440917883
##########
docs/guides/python_packaging.md:
##########
@@ -54,7 +54,8 @@ def add_one(x):
This approach is like using {py:mod}`ctypes` to load and run DLLs, except we
have more powerful features:
-- We can pass in and return a richer set of data types such as
{py:class}`tvm_ffi.Tensor` and strings.
+- We can pass in `torch.Tensor`(or any other DLPack-compatible arrays)
+- We can pass in richer set of data structures such as strings, tuple, dict.
Review Comment:
There are a couple of grammatical and formatting issues in these lines:
* On line 57, there should be a space between `` `torch.Tensor` `` and
`(or...`.
* Both lines are missing a period at the end, which is inconsistent with
other items in the list.
* On line 58, the article "a" is missing before "richer set". Also, for
consistency, `tuple` and `dict` should probably be plural like `strings`.
Here is a suggested correction:
```suggestion
- We can pass in `torch.Tensor` (or any other DLPack-compatible arrays).
- We can pass in a richer set of data structures such as strings, tuples,
and dicts.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
