SystemPanic commented on PR #159: URL: https://github.com/apache/tvm-ffi/pull/159#issuecomment-3414183019
@junrushao You are right, cute::Tensor comes from the project where tvm_ffi was included, FlashInfer, not from tvm_ffi standalone compilation itself. MSVC just was looking for a definition of Tensor. PR description updated Anyway, compilation error is still valid, forward declaration is required to avoid this type of issues with MSVC, as is being used at https://github.com/apache/tvm-ffi/blob/39d675d5f9674345c040aae99b3b3a67b3f270a2/include/tvm/ffi/container/tensor.h#L172 before the class declaration at https://github.com/apache/tvm-ffi/blob/39d675d5f9674345c040aae99b3b3a67b3f270a2/include/tvm/ffi/container/tensor.h#L244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
