gemini-code-assist[bot] commented on code in PR #139:
URL: https://github.com/apache/tvm-ffi/pull/139#discussion_r2434224944
##########
cmake/Utils/AddLibbacktrace.cmake:
##########
@@ -37,6 +37,12 @@ function (_libbacktrace_compile)
file(MAKE_DIRECTORY ${libbacktrace_prefix}/lib)
detect_target_triple(TVM_FFI_MACHINE_NAME)
message(STATUS "Detected target triple: ${TVM_FFI_MACHINE_NAME}")
+
+ # Add symbol hiding flags for GCC and Clang
+ set(symbol_hiding_flags "")
+ if(CMAKE_C_COMPILER_ID MATCHES "GNU|Clang")
Review Comment:
To improve compatibility, it's a good idea to apply these visibility flags
for other GCC-compatible compilers as well, such as Apple's Clang
(`AppleClang`) and the Intel C compiler (`Intel`).
```
if(CMAKE_C_COMPILER_ID MATCHES "GNU|Clang|AppleClang|Intel")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
