junrushao commented on code in PR #168: URL: https://github.com/apache/tvm-ffi/pull/168#discussion_r2441474147
########## docs/get_started/quickstart.rst: ########## @@ -266,29 +269,33 @@ Ship Across Languages --------------------- TVM-FFI's core loading mechanism is ABI stable and works across language boundaries. -That said, a single artifact can be loaded in every language TVM-FFI supports, -without having to recompile different artifact targeting different ABIs or languages. +A single artifact can be loaded in every language TVM-FFI supports, +without having to recompile different artifacts targeting different ABIs or languages. Python ~~~~~~ -As shown in the :ref:`previous section<sec-use-across-framework>`, :py:func:`tvm_ffi.load_module` loads a language- and framework-neutral ``libmain.so`` and supports incorporating it into all Python frameworks that implements the standard `DLPack protocol <https://data-apis.org/array-api/2024.12/design_topics/data_interchange.html>`_. +As shown in the :ref:`previous section<sec-use-across-framework>`, :py:func:`tvm_ffi.load_module` loads a language- and framework-independent ``libmain.so`` +and supports incorporating it into all Python array frameworks that implement the standard `DLPack protocol <https://data-apis.org/array-api/2024.12/design_topics/data_interchange.html>`_. C++ ~~~ -TVM-FFI's C++ API :cpp:func:`tvm::ffi::Module::LoadFromFile` loads ``libmain.so`` and can be used directly in C/C++ with no Python dependency. Note that it is also ABI stable and can be used without having to worry about C++ compilers and ABIs. +TVM-FFI's C++ API :cpp:func:`tvm::ffi::Module::LoadFromFile` loads ``libmain.so`` and can be used directly in C/C++ with no Python dependency. .. code-block:: cpp // File: test_load.cc + #include <tvm/ffi/container/tensor.h> #include <tvm/ffi/extra/module.h> - int main() { - namespace ffi = tvm::ffi; + namespace ffi = tvm::ffi; + + int call_add_one(ffi::TensorView x, ffi::TensorView y) { Review Comment: note that you can't call `./test_load` if this change is made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
