gemini-code-assist[bot] commented on code in PR #119: URL: https://github.com/apache/tvm-ffi/pull/119#discussion_r2430197057
########## KEYS: ########## @@ -0,0 +1,74 @@ +This file contains the PGP keys of various developers. +Please don't use them for email unless you have to. Their main +purpose is code signing. + +Examples of importing this file in your keystore: + gpg --import KEYS.txt Review Comment:  The filename in the example command is `KEYS.txt`, but the actual filename is `KEYS`. This should be corrected to avoid confusion for users trying to import the keys. ``` gpg --import KEYS ``` ########## KEYS: ########## @@ -0,0 +1,74 @@ +This file contains the PGP keys of various developers. +Please don't use them for email unless you have to. Their main +purpose is code signing. + +Examples of importing this file in your keystore: + gpg --import KEYS.txt + (need pgp and other examples here) Review Comment:  This line appears to be a placeholder comment `(need pgp and other examples here)`. It should be removed or replaced with actual examples if available. ########## KEYS: ########## @@ -0,0 +1,74 @@ +This file contains the PGP keys of various developers. +Please don't use them for email unless you have to. Their main +purpose is code signing. + +Examples of importing this file in your keystore: + gpg --import KEYS.txt + (need pgp and other examples here) + +Examples of adding your key to this file: + pgp -kxa <your name> and append it to this file. + (pgpk -ll <your name> && pgpk -xa <your name>) >> this file. + (gpg --list-sigs <your name> + && gpg --armor --export <your name>) >> this file. Review Comment:  The instructions for adding a key contain non-standard commands (`pgp`, `pgpk`) and placeholders (`this file`). It would be better to provide a single, clear example using the standard `gpg` tool and the correct filename. ``` # To add your key, run the following command, replacing <key-id> with your GPG key ID. # You can find your key ID with `gpg --list-keys`. (gpg --list-sigs <key-id> \ && gpg --armor --export <key-id>) >> KEYS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
