gemini-code-assist[bot] commented on code in PR #61:
URL: https://github.com/apache/tvm-ffi/pull/61#discussion_r2383564847
##########
tests/python/test_object.py:
##########
@@ -53,6 +53,15 @@ def test_attribute() -> None:
assert type(obj).b.__doc__ == "Field `b`"
+def test_attribute_no_doc() -> None:
+ from tvm_ffi.testing import TestObjectBase # noqa: PLC0415
+
+ # The docs are None because they are neither explicitly set in C++ nor in
Python.
Review Comment:
The comment is slightly misleading. It states that docs are `None` because
they are not set, but the assertion on the next line for `v_i64.__doc__`
contradicts this. For better clarity, the comment should specify which fields
are expected to have `None` docstrings.
```suggestion
# The docs for v_f64 and v_str are None because they are not explicitly
set.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
