gemini-code-assist[bot] commented on code in PR #50:
URL: https://github.com/apache/tvm-ffi/pull/50#discussion_r2373379503
##########
python/tvm_ffi/container.py:
##########
@@ -117,14 +117,12 @@ def __init__(self, input_list: Iterable[T]) -> None:
def __getitem__(self, idx: SupportsIndex, /) -> T: ...
@overload
- def __getitem__(self, idx: slice, /) -> Array[T]: ...
+ def __getitem__(self, idx: slice, /) -> list[T]: ...
- def __getitem__(self, idx: SupportsIndex | slice, /) -> T | Array[T]:
+ def __getitem__(self, idx: SupportsIndex | slice, /) -> T | list[T]:
Review Comment:
While the type hints for `__getitem__` have been correctly updated to
reflect the change in return type for slicing, the docstring on line 123 is now
out of date. It still states that a slice returns a `:class:'Array'`, which
could be misleading. Please update the docstring to align with the new behavior.
For example:
```python
"""Return one element or a list for a slice."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
