gemini-code-assist[bot] commented on code in PR #46: URL: https://github.com/apache/tvm-ffi/pull/46#discussion_r2371222540
########## .yamllint.yaml: ########## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +extends: default + +rules: + document-start: disable + line-length: + max: 120 + level: warning + truthy: + allowed-values: + - "on" + - "off" + - "yes" + - "no" + - "true" + - "false" Review Comment:  The current configuration for the `truthy` rule is very permissive, allowing multiple string representations for boolean values (`on`/`off`, `yes`/`no`, `true`/`false`). For better consistency across the codebase, it's recommended to enforce a stricter style by only allowing `true` and `false`. This is also the default behavior of `yamllint`. ```yaml truthy: allowed-values: ["true", "false"] ``` ########## .markdownlint-cli2.yaml: ########## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +config: + MD013: false Review Comment:  Disabling the line length check (`MD013`) completely might not be ideal, as it can lead to very long lines in documentation, which harms readability. Consider a more nuanced configuration that sets a reasonable line length for text but disables it for code blocks and tables where long lines are more common and harder to wrap. This would provide a better balance between linting and practicality. ```yaml MD013: line_length: 120 code_blocks: false tables: false ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
