gemini-code-assist[bot] commented on code in PR #60:
URL: https://github.com/apache/tvm-ffi/pull/60#discussion_r2383219738
##########
src/ffi/extra/testing.cc:
##########
@@ -58,8 +58,8 @@ class TestIntPair : public tvm::ffi::ObjectRef {
TVM_FFI_STATIC_INIT_BLOCK() {
namespace refl = tvm::ffi::reflection;
refl::ObjectDef<TestIntPairObj>()
- .def_ro("a", &TestIntPairObj::a)
- .def_ro("b", &TestIntPairObj::b)
+ .def_ro("a", &TestIntPairObj::a, "Field `a`")
+ .def_ro("b", &TestIntPairObj::b, "Field `b`")
Review Comment:
The docstrings for fields `a` and `b` are a bit generic. To improve clarity
and consistency with the Python docstring for `TestIntPair` in
`python/tvm_ffi/testing.py`, consider making these more descriptive. The Python
docstring describes `a` as "The first integer." and `b` as "The second
integer.". Using these descriptions here would make the property docstrings
more helpful.
```c
.def_ro("a", &TestIntPairObj::a, "The first integer.")
.def_ro("b", &TestIntPairObj::b, "The second integer.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
