junrushao opened a new pull request, #91:
URL: https://github.com/apache/tvm-ffi/pull/91
When generation function schema for member functions of a certain class, the
existing logics overlooked `this` as the first argument, which, as a result,
generates inproper number of arguments.
More specifically, in the snippet below,
```C++
class MyCls {
void MyFunc(int a);
};
refl::GlobalDef()
.def_method("MyCls_MyFunc", &MyCls::MyFunc);
```
the global method `MyCls_MyFunc` is supposed to have signature `(MyCls, int)
-> None`, but the implementation on mainline gives `(int) -> None`.
This PR fixes this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
