gemini-code-assist[bot] commented on code in PR #162: URL: https://github.com/apache/tvm-ffi/pull/162#discussion_r2438585749
########## pyproject.toml: ########## @@ -226,7 +226,7 @@ build-verbosity = 1 # will be abi3 and can be used in future versions # ship 314t threaded nogil version build = ["cp38-*", "cp39-*", "cp310-*", "cp311-*", "cp312-*", "cp314t-*"] -skip = ["*musllinux*", "cp38-macosx_*"] +skip = ["*musllinux*"] Review Comment:  While this change re-enables the build for Python 3.8 on macOS, the tests for it are still skipped due to the `test-skip` configuration on line 231. Building wheels without running tests for them is risky as it might lead to shipping broken packages. It would be safer to also enable tests for the `cp38-macosx_*` build. You could consider updating `test-skip` to enable tests for this specific configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
