gemini-code-assist[bot] commented on code in PR #105: URL: https://github.com/apache/tvm-ffi/pull/105#discussion_r2424754982
########## pyproject.toml: ########## @@ -60,6 +60,7 @@ docs = [ "sphinx-autobuild", "sphinx-book-theme", "sphinx-copybutton", + "sphinx-design", Review Comment:  To ensure reproducible documentation builds, it's a best practice to pin dependency versions. A new version of `sphinx-design` could introduce unexpected changes or break the build. Please add a version specifier. ```suggestion "sphinx-design==0.6.0", ``` ########## docs/conf.py: ########## @@ -46,6 +46,7 @@ "myst_parser", "nbsphinx", "autodocsumm", + "sphinx_design", Review Comment:  For better maintainability, consider keeping the `extensions` list sorted alphabetically. This makes it easier to see what extensions are enabled and avoid duplicates. ########## docs/.rstcheck.cfg: ########## @@ -1,4 +1,5 @@ [rstcheck] report_level = warning -ignore_directives = automodule, autosummary, currentmodule, toctree, ifconfig -ignore_roles = ref, cpp:class, cpp:func, py:func +ignore_directives = automodule, autosummary, currentmodule, toctree, ifconfig, tab-set, collapse, tabs +ignore_roles = ref, cpp:class, cpp:func, py:func, c:macro Review Comment:  For better maintainability, it's good practice to keep this list of roles sorted alphabetically. This makes it easier to scan the list and add new items in the future. ``` ignore_roles = c:macro, cpp:class, cpp:func, py:func, ref ``` ########## docs/.rstcheck.cfg: ########## @@ -1,4 +1,5 @@ [rstcheck] report_level = warning -ignore_directives = automodule, autosummary, currentmodule, toctree, ifconfig -ignore_roles = ref, cpp:class, cpp:func, py:func +ignore_directives = automodule, autosummary, currentmodule, toctree, ifconfig, tab-set, collapse, tabs Review Comment:  For better maintainability, it's good practice to keep this list of directives sorted alphabetically. This makes it easier to scan the list and add new items in the future. ``` ignore_directives = automodule, autosummary, collapse, currentmodule, ifconfig, tab-set, tabs, toctree ``` ########## pyproject.toml: ########## @@ -60,6 +60,7 @@ docs = [ "sphinx-autobuild", "sphinx-book-theme", "sphinx-copybutton", + "sphinx-design", "sphinx-reredirects==0.1.2", "sphinx-tabs==3.4.1", Review Comment:  `sphinx-design` provides functionality for tabs, which could replace `sphinx-tabs`. To simplify dependencies, you might consider migrating existing tabs to use `sphinx-design` and removing the `sphinx-tabs` dependency in this or a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
