gemini-code-assist[bot] commented on code in PR #136: URL: https://github.com/apache/tvm-ffi/pull/136#discussion_r2433817993
########## pyproject.toml: ########## @@ -47,10 +47,26 @@ test = [ "pytest", "numpy", "ninja", - "torch; python_version < '3.14' and sys_platform != 'win32'", + "torch>=2.9; '3.9' < python_version and python_version < '3.14'", ] [dependency-groups] +dev = [ + "ruff", + "mypy", + "clang-format", + "clang-tidy", + "ipdb", + "ipython", + "ninja", + "pre-commit", + "pytest", + "numpy", + "ml_dtypes", + "cython", + "cmake", + "scikit-build-core", +] Review Comment:  The new `dev` dependency group duplicates several dependencies that are already defined elsewhere in `pyproject.toml`: * `pytest`, `numpy`, and `ninja` are also in the `test` optional dependencies. * `cython`, `cmake`, and `scikit-build-core` are also in `[build-system].requires`. This duplication can make dependency management more difficult and error-prone. To improve maintainability, it's best to define each dependency in a single place. Consider restructuring the dependency groups to remove this redundancy. For example, if your tooling supports it, you could define the `dev` group to include the `test` group. ########## pyproject.toml: ########## @@ -47,10 +47,26 @@ test = [ "pytest", "numpy", "ninja", - "torch; python_version < '3.14' and sys_platform != 'win32'", + "torch>=2.9; '3.9' < python_version and python_version < '3.14'", Review Comment:  The updated dependency marker for `torch` is `'3.9' < python_version and python_version < '3.14'`, which excludes Python 3.9. However, the project's `requires-python` is set to `>=3.9`, indicating that Python 3.9 is a supported version. Excluding `torch` for tests on Python 3.9 could lead to an incomplete testing setup for local development and might cause issues for developers using this version. If `torch>=2.9` supports Python 3.9, the constraint should be inclusive. ```suggestion "torch>=2.9; python_version >= '3.9' and python_version < '3.14'" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
