junrushao commented on code in PR #283: URL: https://github.com/apache/tvm-ffi/pull/283#discussion_r2553214697
########## include/tvm/ffi/extra/cubin_launcher.h: ########## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +/*! + * \file tvm/ffi/extra/cubin_launcher.h + * \brief CUDA CUBIN launcher utility for loading and executing CUDA kernels. + * + * This header provides a lightweight C++ wrapper around CUDA Driver API + * for loading CUBIN modules and launching kernels. It supports: + * - Loading CUBIN from memory (embedded data) or files + * - Multi-GPU execution using CUDA primary contexts + * - Kernel parameter management and launch configuration + */ +#ifndef TVM_FFI_EXTRA_CUBIN_LAUNCHER_H_ Review Comment: I'm not entirely sure if it may look like we are introducing extra cuda dependency (which we don't) by adding this extra file into `include/` directory. In fact, there are only a few driver APIs it is using: - cuInit - cuGetErrorName - cuGetErrorString - cuLibraryLoadData - cuLibraryUnload - cuLibraryGetKernel - cuKernelGetFunction - cuLaunchKernel Is it a good way if we could potentially not have to expose this header? e.g. hiding this in `example/`, etc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
