junrushao commented on code in PR #286: URL: https://github.com/apache/tvm-ffi/pull/286#discussion_r2567397681
########## include/tvm/ffi/function.h: ########## @@ -33,15 +33,20 @@ #define TVM_FFI_DLL_EXPORT_INCLUDE_METADATA 0 #endif +#if TVM_FFI_DLL_EXPORT_INCLUDE_METADATA Review Comment: I see. I’ve got bunch of similar warnings too. I managed to run clangd on this repo on mainline CI, but it only applies to .cc files instead of headers. If you have any ideas how to improve, I’m happy to walk you through what the existing infra looks like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
