guan404ming commented on PR #18521: URL: https://github.com/apache/tvm/pull/18521#issuecomment-3591775913
> Isn’t the test passing successfully even without making any changes? @guan404ming It's passing on my env with torch==2.5.0. It also passes on my environment (torch 2.9.0). I removed that redundant test. The check is kind of defensive programming. It prevents a future `NoneType` error if later adds support for data-dependent output shapes (e.g., `nonzero`) and someone calls `.shape[dim]` on such results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
