gemini-code-assist[bot] commented on code in PR #303:
URL: https://github.com/apache/tvm-ffi/pull/303#discussion_r2582678161


##########
python/tvm_ffi/_optional_torch_c_dlpack.py:
##########
@@ -116,7 +116,7 @@ def load_torch_c_dlpack_extension() -> Any:  # noqa: 
PLR0912, PLR0915
         libname = 
f"libtorch_c_dlpack_addon_torch{major}{minor}-{device}{suffix}"
         lib_path = addon_output_dir / libname
         if not lib_path.exists():
-            logger.info("JIT-compiling torch-c-dlpack-ext to cache...")
+            logger.debug("JIT-compiling torch-c-dlpack-ext to cache...")

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   To improve debuggability, it would be helpful to include the path of the 
cached library in this log message. This would allow developers to quickly 
locate the JIT-compiled file without having to trace how the path is 
constructed in the code.
   
   ```suggestion
               logger.debug(f"JIT-compiling torch-c-dlpack-ext to cache: 
{lib_path}")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to