gemini-code-assist[bot] commented on code in PR #18542:
URL: https://github.com/apache/tvm/pull/18542#discussion_r2585811181
##########
src/arith/int_set.cc:
##########
@@ -532,10 +532,7 @@ class IntervalSetEvaluator : public
ExprFunctor<IntervalSet(const PrimExpr&)> {
}
IntervalSet VisitExpr_(const BroadcastNode* op) final {
- if (!eval_vec_) {
- DLOG(WARNING) << "cannot evaluate set on expression " <<
ffi::GetRef<PrimExpr>(op);
- return IntervalSet::Everything();
- }
+ ICHECK(eval_vec_);
Review Comment:
This change reverts apache/tvm#18536, restoring the `ICHECK(eval_vec_)`.
While this makes the behavior consistent with `VisitExpr_(const RampNode* op)`,
it may re-introduce the `InternalError` that the original PR aimed to fix. If
the underlying issue causing this method to be called with `eval_vec_ == false`
has been addressed elsewhere, then this revert is correct. Otherwise, we might
see the same crash again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
