gemini-code-assist[bot] commented on code in PR #18575:
URL: https://github.com/apache/tvm/pull/18575#discussion_r2606092400
##########
tests/python/relax/test_frontend_onnx.py:
##########
@@ -2440,6 +2440,8 @@ def verify_pad(input_shape, pads, mode="constant",
value=0.0):
verify_pad((2, 3), [1, 0, 0, 1], "constant", 0.0)
verify_pad((3, 2), [0, 0, 1, 0], "constant", 5.0)
verify_pad((1, 3, 4, 5), [0, 1, 1, 1, 0, 0, 1, 1], "reflect")
+ verify_pad((2, 3), [1, 1, 1, 1], "edge")
+ verify_pad((1, 3, 4, 5), [0, 1, 1, 1, 0, 0, 1, 1], "edge")
Review Comment:
These test cases for 'edge' padding are also added to `test_pad_v2`. To
avoid code duplication, consider merging `test_pad` and `test_pad_v2` into a
single parameterized test that takes the ONNX opset version as a parameter.
This would make the tests more maintainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
