gemini-code-assist[bot] commented on code in PR #18576:
URL: https://github.com/apache/tvm/pull/18576#discussion_r2606226669
##########
python/tvm/relax/frontend/nn/llm/position_embedding.py:
##########
@@ -197,8 +197,8 @@ def yarn_find_correction_range(
max_position_embeddings: int,
):
"""Find the correction range based on the number of rotations"""
- low = tir.floor(yarn_find_correction_dim(low_rot, d, theta,
max_position_embeddings))
- high = tir.ceil(yarn_find_correction_dim(high_rot, d, theta,
max_position_embeddings))
+ low = yarn_find_correction_dim(low_rot, d, theta, max_position_embeddings))
+ high = yarn_find_correction_dim(high_rot, d, theta,
max_position_embeddings))
Review Comment:
There appears to be a syntax error in these lines. Each line has an extra
closing parenthesis `)` at the end, which will lead to a `SyntaxError`. Please
remove the extraneous parentheses.
```suggestion
low = yarn_find_correction_dim(low_rot, d, theta,
max_position_embeddings)
high = yarn_find_correction_dim(high_rot, d, theta,
max_position_embeddings)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
