yaoyaoding commented on code in PR #300: URL: https://github.com/apache/tvm-ffi/pull/300#discussion_r2632775602
########## cmake/Utils/EmbedCubin.cmake: ########## @@ -15,205 +15,163 @@ # specific language governing permissions and limitations # under the License. +# Do not let cmake to link cudart. +set(CMAKE_CUDA_RUNTIME_LIBRARY None) Review Comment: I still think a utility should not change the global configuration like CMAKE_CUDA_RUNTIME_LIBRARY. Maybe we can add explicit remindar in the documentation of the macro ``` TVM_FFI_CUBIN_LAUNCHER_USE_DRIVER_API ``` to remind the user that the default behavior of cmake and CMAKE_CUDA_RUNTIME_LIBRARY to ask them to set it to None in their cmake when they want to use driver api only, otherwise their compiled binary will have a unnecessary runtime library and thus some dependency on driver version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
