w169q169 commented on PR #18604: URL: https://github.com/apache/tvm/pull/18604#issuecomment-3688883817
> thanks a lot for the contribution, to align with existing impl, we can use launch param tag, see LaunchParamConfig implementation. The launch param tag can be specified as part of `tir.kernel_launch_params`, which then set the LaunchPramConfig setting > > we can use > > constexpr const char* kUseProgramaticDependentLaunch = "tir.use_programtic_dependent_launch"; > > * add a field use_programtic_dependent_launch_ to field to LaunchConfig > * expose a function use_programtic_dependent_launch() which can be queried in LaunchConfig > > This way we can directly specify pdl properties in the tvmscript as kernel function attribute Thanks for the detailed guidance. I have updated the PR according to your suggestions. Please let me know if there are any further comments or improvements needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
