gemini-code-assist[bot] commented on code in PR #18667: URL: https://github.com/apache/tvm/pull/18667#discussion_r2698060524
########## tests/python/relax/test_op_size.py: ########## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import numpy as np + +import tvm +import tvm.testing +from tvm import relax +from tvm.script import relax as R + + +def test_op_size(): + @tvm.script.ir_module + class Module: + @R.function + def main(x: R.Tensor((2, 3), "float32")) -> R.Tensor((), "int64"): + return R.size(x) + + x_np = np.random.rand(2, 3).astype("float32") + x = tvm.runtime.tensor(x_np) + + target = tvm.target.Target("llvm") + ex = relax.build(Module, target) + vm = relax.VirtualMachine(ex, tvm.cpu()) + + res = vm["main"](x) + assert res.numpy() == 6 + + +def test_op_size_dynamic(): + @tvm.script.ir_module + class Module: + @R.function + def main(x: R.Tensor(("m", "n"), "float32")) -> R.Tensor((), "int64"): + return R.size(x) + + x_np = np.random.rand(4, 5).astype("float32") + x = tvm.runtime.tensor(x_np) + + target = tvm.target.Target("llvm") + ex = relax.build(Module, target) + vm = relax.VirtualMachine(ex, tvm.cpu()) + + res = vm["main"](x) + assert res.numpy() == 20 + + +if __name__ == "__main__": + tvm.testing.main() Review Comment:  The current tests cover static and dynamic shapes, which is great. To make the test suite more robust, consider adding tests for a few edge cases: 1. **Scalar input (0-dimensional tensor)**: The size should be 1. 2. **Tensor with a zero-sized dimension**: The size should be 0. Here are some examples of how you could write these tests: ```python def test_op_size_scalar(): @tvm.script.ir_module class Module: @R.function def main(x: R.Tensor((), "float32")) -> R.Tensor((), "int64"): return R.size(x) x_np = np.array(1.0, dtype="float32") x = tvm.runtime.tensor(x_np) target = tvm.target.Target("llvm") ex = relax.build(Module, target) vm = relax.VirtualMachine(ex, tvm.cpu()) res = vm["main"](x) assert res.numpy() == 1 def test_op_size_zero_dim(): @tvm.script.ir_module class Module: @R.function def main(x: R.Tensor((2, 0, 3), "float32")) -> R.Tensor((), "int64"): return R.size(x) x_np = np.empty((2, 0, 3), dtype="float32") x = tvm.runtime.tensor(x_np) target = tvm.target.Target("llvm") ex = relax.build(Module, target) vm = relax.VirtualMachine(ex, tvm.cpu()) res = vm["main"](x) assert res.numpy() == 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
